[AI-FSSDK] [FSSDK-12369] Add local holdouts support to JavaScript SDK#1151
Merged
Conversation
|
coverage: 77.761% (-0.1%) from 77.906% — ai/mat001/FSSDK-12369-local-holdouts into master |
…00% local holdout
raju-opti
approved these changes
May 22, 2026
Contributor
raju-opti
left a comment
raju-opti
left a comment
There was a problem hiding this comment.
I would like to refactor few thing. But good for now
| * When present, the caller should use this as the full decision result | ||
| * instead of constructing one from the experiment. | ||
| */ | ||
| localHoldoutDecision?: DecisionObj; |
Contributor
There was a problem hiding this comment.
This field does not make sense inside this type. This will work functionally now, but I would like to refactor it later
|
|
||
| // Level 2 decision service tests for local holdouts (FSSDK-12369) | ||
| // One test per branch of the pseudocode in Step 3 of the ticket. | ||
| describe('local holdouts (FSSDK-12369)', () => { |
Contributor
There was a problem hiding this comment.
please remove ticket number from the title
| }); | ||
| }); | ||
|
|
||
| // Level 2 decision service tests for local holdouts (FSSDK-12369) |
Contributor
There was a problem hiding this comment.
please remove the ticket number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Local Holdouts support to the JavaScript SDK. Local holdouts allow targeting specific experiment or delivery rules within a flag, while global holdouts (the existing behavior) apply to all rules across all flags. This introduces a new rule-level targeting system using an
includedRulesfield on the holdout data model.Changes
includedRulesandisGlobalfields to theHoldoutinterface inshared_types.tsHoldoutConfiginterface andgetGlobalHoldouts/getHoldoutsForRulehelper functions toproject_config.ts;parseHoldoutsConfignow builds and stores these lookups during config initializationdecision_service/index.tsto evaluate global holdouts viagetGlobalHoldouts()at flag level and check local holdouts per-rule (after forced decisions, before regular rule evaluation) for both experiment rules and delivery rulesJira Ticket
FSSDK-12369